Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-warehouse): add missing config for salesforce incremental #25322

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Oct 1, 2024

Problem

  • in changing all salesforce fields to incremental, some config was still missing

Changes

  • add missing config

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@EDsCODE EDsCODE requested a review from a team October 1, 2024 18:17
Copy link
Member

@raquelmsmith raquelmsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👀

@EDsCODE EDsCODE enabled auto-merge (squash) October 1, 2024 18:21
@EDsCODE EDsCODE merged commit b110a43 into master Oct 1, 2024
87 checks passed
@EDsCODE EDsCODE deleted the dw-salesforce-all-incremental-2 branch October 1, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants