-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor-3000): integrate nav3000 sidebar #26184
base: master
Are you sure you want to change the base?
Conversation
📸 UI snapshots have been updated6 snapshot changes in total. 0 added, 6 modified, 0 deleted:
Triggered by this commit. |
…nto dw-sidebar-integration
Size Change: 0 B Total Size: 1.16 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🚢 Would love to get your opinion, but I think as a follow on from this, I'd like to see us drop the phrase "external sources" and instead just have "sources", of which PostHog is one. Im unsure on separating our sources and posthog tables under different sections - I feel like it makes sense to have all of this under one heading:
--------
Sources
--------
+ Posthog
- events
- persons
+ Stripe
- customers
--------
Problem
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?