Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor-3000): integrate nav3000 sidebar #26184

Open
wants to merge 54 commits into
base: master
Choose a base branch
from

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Nov 13, 2024

Problem

  • sidebar is just for show

Changes

  • use existing sidebar component in sql editor
Screenshot 2024-11-14 at 2 37 48 PM

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@EDsCODE EDsCODE changed the base branch from master to dw-editor-logic-refactor November 13, 2024 22:53
@EDsCODE EDsCODE mentioned this pull request Nov 14, 2024
24 tasks
@EDsCODE EDsCODE marked this pull request as ready for review November 14, 2024 19:37
@EDsCODE EDsCODE requested a review from a team November 14, 2024 19:38
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

6 snapshot changes in total. 0 added, 6 modified, 0 deleted:

  • chromium: 0 added, 6 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

github-actions bot commented Nov 14, 2024

Size Change: 0 B

Total Size: 1.16 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.16 MB

compressed-size-action

Copy link
Member

@Gilbert09 Gilbert09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚢 Would love to get your opinion, but I think as a follow on from this, I'd like to see us drop the phrase "external sources" and instead just have "sources", of which PostHog is one. Im unsure on separating our sources and posthog tables under different sections - I feel like it makes sense to have all of this under one heading:

--------
Sources
--------
+ Posthog
  - events
  - persons
+ Stripe
  - customers
--------

Base automatically changed from dw-editor-logic-refactor to master November 15, 2024 17:43
@EDsCODE EDsCODE changed the title feat(data-warehouse): integrate nav3000 sidebar feat(editor-3000): integrate nav3000 sidebar Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants