-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(max): OpenAI data processing opt-in #26248
Open
Twixes
wants to merge
8
commits into
master
Choose a base branch
from
max-openai-clarity
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +14 B (0%) Total Size: 1.16 MB ℹ️ View Unchanged
|
This comment was marked as outdated.
This comment was marked as outdated.
Twixes
force-pushed
the
max-openai-clarity
branch
from
November 18, 2024 16:12
0591f9d
to
ed848b1
Compare
📸 UI snapshots have been updated6 snapshot changes in total. 0 added, 6 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We need to be clear that the AI assistant uses an external LLM providers to analyze data – OpenAI currently – including possibly personal data of users (e.g. emails).
Changes
Let's keep things lightweight but informative. This introduces an OpenAI processing popover, which every user must accept to use Max. Should give you clarity on use of data, without being formal or otherwise blocking adoption.
We might amend this with "Anthropic" (Claude) or "Google" (Gemini) in the future, but since this is not a DPA, we're free to update this any time.
We probably will want to link to DPA signing here, but I believe not a blocker while rollout is limited (CC @fraserhopper though).
How did you test this code?
Should show up in UI snapshots.