fix(flags): prevent kea logic loop and clean filters on tab switch #26258
+12
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havenbarnes
commented
Nov 18, 2024
| if (page !== undefined) { | ||
| pageFiltersFromUrl.page = parseInt(page) | ||
| } | ||
| pageFiltersFromUrl.active = active ? String(active) : undefined |
There was a problem hiding this comment.
This is the primary bug fix, it keeps the comparison with DEFAULT_FILTERS a few lines down stable regardless of present search params
|
Size Change: 0 B Total Size: 1.16 MB ℹ️ View Unchanged
|
havenbarnes
commented
Nov 18, 2024
| * so let's update filter state if it changes | ||
| */ | ||
| const isChangingPage = page !== undefined && page !== values.filters.page | ||
| if (isInitializingFilters || isChangingPage) { |
There was a problem hiding this comment.
These checks were previously preventing a loop, but aren't needed; the new diff
setActiveTab: () => {
// Don't carry over pagination from previous tab
actions.setFeatureFlagsFilters({ page: 1 }, true)
},
prevents this loop by resetting the filters properly. Not having this check ensures we (properly) reload the table whenever we navigate back to the features list
dmarticus
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Issue resolved by #26257 re-occurred, after investigating I found that a fresh navigation to the FF UI still exhibits the
Maximum call stack size exceedederror here:https://posthog.sentry.io/issues/6063840317/?notification_uuid=65ceb7bd-8e81-49e2-bb7b-956fddd59861&project=1899813&referrer=regression_activity-email
Changes
pagesearch param being carried over between tab switchesDoes this work well for both Cloud and self-hosted?
Yes
How did you test this code?
https://www.loom.com/share/b5e4c76aba3e4d63b0218e96d51da944