New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(insights): prevent race condition #26265

Open

EDsCODE wants to merge 1 commit into master from insight-async-race-condition

+7 −3

Member

EDsCODE commented Nov 19, 2024

Problem

when developing locally, the minimal latency is causing a race condition on the async insight processing
the query status in the kick off function is overwriting the query result from the task

Changes

pass in a custom task_id that can be set first before the task is run

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?


          prevent race condition

2575ed1

EDsCODE requested a review from a team

November 19, 2024 02:24

anirudhpillai approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet