Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(experiments HogQL): add migration command #26271

Merged
merged 1 commit into from
Nov 19, 2024
Merged

feat(experiments HogQL): add migration command #26271

merged 1 commit into from
Nov 19, 2024
+74 −0

Conversation

jurajmajerik
Copy link
Contributor

Changes

^^

How did you test this code?

Locally, the experiments and their results match up under the old and new code handling.

danielbachhuber
danielbachhuber approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the command locally and verified it migrated the primary metric, secondary metric, and custom exposures for my experiments.

@jurajmajerik jurajmajerik merged commit 7b36e5f into master Nov 19, 2024
90 checks passed
@jurajmajerik jurajmajerik deleted the migrate-experiments-command branch November 19, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbachhuber danielbachhuber danielbachhuber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jurajmajerik @danielbachhuber