Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Action.DoesNotExist more #5028

Merged
merged 5 commits into from
Jul 8, 2021
Merged

Conversation

Twixes
Copy link
Collaborator

@Twixes Twixes commented Jul 7, 2021

Changes

Resolves #5026.

@timgl timgl temporarily deployed to posthog-pr-5028 July 7, 2021 13:26 Inactive
@Twixes Twixes temporarily deployed to posthog-pr-5028 July 7, 2021 14:00 Inactive
@Twixes Twixes requested a review from EDsCODE July 7, 2021 14:16
Copy link
Collaborator

@neilkakkar neilkakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very noice.

A regression test please for non-existing actions?

@Twixes Twixes temporarily deployed to posthog-pr-5028 July 8, 2021 21:30 Inactive
@Twixes Twixes enabled auto-merge (squash) July 8, 2021 21:39
@Twixes Twixes merged commit a599056 into master Jul 8, 2021
@Twixes Twixes deleted the handle-action-doesnotexist-more branch July 8, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action not existing is not handled in the funnel query
3 participants