Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add median time for funnel conversion data #5203

Merged
merged 8 commits into from
Jul 20, 2021
Merged

Add median time for funnel conversion data #5203

merged 8 commits into from
Jul 20, 2021

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Jul 19, 2021

Changes

Please describe.

  • adds median conversion time per step as parameter median_conversion_time on funnel step results
    If this affects the frontend, include screenshots.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
  • New/changed UI is decent on smartphones (viewport width around 360px)

@timgl timgl temporarily deployed to posthog-pr-5203 July 19, 2021 18:42 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-pr-5203 July 19, 2021 19:32 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-pr-5203 July 19, 2021 19:35 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-pr-5203 July 19, 2021 19:39 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-pr-5203 July 19, 2021 20:33 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-pr-5203 July 19, 2021 21:01 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-pr-5203 July 19, 2021 21:27 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-pr-5203 July 19, 2021 21:47 Inactive
@EDsCODE EDsCODE mentioned this pull request Jul 19, 2021
Closed
@EDsCODE EDsCODE requested a review from neilkakkar July 20, 2021 15:59
@neilkakkar
Copy link
Collaborator

Related to: #5174 - but makes sense for this to go in first!

@EDsCODE EDsCODE merged commit cedf33c into master Jul 20, 2021
@EDsCODE EDsCODE deleted the median-time-funnel branch July 20, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilkakkar neilkakkar Awaiting requested review from neilkakkar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EDsCODE @neilkakkar @timgl