-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade aeson to 2.0.* #2292
Upgrade aeson to 2.0.* #2292
Changes from all commits
5e6987b
48a3d1d
2b8ffc8
e42bf30
bb62e55
7531c54
f5afa41
b056735
12967f8
ff56c3a
14c882a
34d0f34
d7f54e7
63ebf6e
8d8074d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,8 +28,8 @@ let | |
mkdir -p $out/bin | ||
ln -s $hsie $out/bin/$name | ||
''; | ||
bashCompletion = | ||
bash-completion = | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The updated nixpkgs came with deprecation warnings against spelling it There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's weird. it's not about using a camelcase key right? Just about this particular identifier. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, that particular one. It was changed from a warning to an exception here: NixOS/nixpkgs#161146 |
||
runCommand "${name}-bash-completion" { inherit bin name; } | ||
"$bin/bin/$name --bash-completion-script $bin/bin/$name > $out"; | ||
in | ||
hsie // { inherit bashCompletion bin; } | ||
hsie // { inherit bash-completion bin; } |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
# Pinned version of Nixpkgs, generated with postgrest-nixpkgs-upgrade. | ||
{ | ||
date = "2021-11-02"; | ||
rev = "7053541084bf5ce2921ef307e5585d39d7ba8b3f"; | ||
tarballHash = "1flhh5d4zy43x6060hvzjb5hi5cmc51ivc0nwmija9n8d35kcc4x"; | ||
date = "2022-03-30"; | ||
rev = "9a5aa75d56ad4163521f1692469e6dc54b90068c"; | ||
tarballHash = "1f3wyldcx1zpyk2q6122mkg16chf9j7swwx1v6f1dg126xz1238f"; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,16 @@ | ||
# Creates an environment that exposes bashCompletion arguments from all checkedShellScripts | ||
# Creates an environment that exposes bash-completion arguments from all checkedShellScripts | ||
{ buildEnv }: | ||
{ name | ||
, tools | ||
, extra ? { } | ||
}: | ||
let | ||
bashCompletion = builtins.map (tool: tool.bashCompletion) tools; | ||
bash-completion = builtins.map (tool: tool.bash-completion) tools; | ||
|
||
env = buildEnv { | ||
inherit name; | ||
paths = builtins.map (tool: tool.bin) tools; | ||
}; | ||
|
||
in | ||
env // { inherit bashCompletion; } // extra | ||
env // { inherit bash-completion; } // extra |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
diff --git a/survey/default.nix b/survey/default.nix | ||
index 46d8066..5f7950b 100644 | ||
--- a/survey/default.nix | ||
+++ b/survey/default.nix | ||
@@ -85,10 +85,9 @@ let | ||
# Function that tells us if a given Haskell package has an executable. | ||
# Pass only Haskell packages to this! | ||
# Filter away other stuff with `isProperHaskellPackage` first. | ||
- isExecutable = pkg: | ||
- (pkgs.haskell.lib.overrideCabal pkg (drv: { | ||
- passthru.isExecutable = drv.isExecutable or false; | ||
- })).isExecutable; | ||
+ # FIXME postgrest: original fails with our nixpkgs version, we | ||
+ # just hardcode the check to work for a static postgrest build. | ||
+ isExecutable = pkg: pkg.name == "postgrest"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This isn't particularly elegant, but it works. |
||
|
||
# Turn e.g. `Cabal_1_2_3_4` into `1.2.3.4`. | ||
cabalDottedVersion = |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
diff --git a/survey/default.nix b/survey/default.nix | ||
index 46d8066..a47f214 100644 | ||
--- a/survey/default.nix | ||
+++ b/survey/default.nix | ||
@@ -1519,7 +1519,7 @@ let | ||
[ | ||
"--enable-executable-static" # requires `useFixedCabal` | ||
# `enableShared` seems to be required to avoid `recompile with -fPIC` errors on some packages. | ||
- "--extra-lib-dirs=${final.ncurses.override { enableStatic = true; enableShared = true; }}/lib" | ||
+ "--extra-lib-dirs=${final.ncurses}/lib" | ||
] | ||
# TODO Figure out why this and the below libffi are necessary. | ||
# `working` and `workingStackageExecutables` don't seem to need that, |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
{ bashCompletion | ||
{ bash-completion | ||
, buildToolbox | ||
, cabal-install | ||
, checkedShellScript | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd file an issue and/or a follow-up PR to make postgrest hlint-clean for the updated hlint version, and to drop this shim again. But would rather not add linter fixes into the mix here, the PR ballooned enough already.