Bulk update #2311
Merged
Bulk update #2311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unnecessary because root filters don't have an EmbedPath(it's empty)
steve-chavez
force-pushed
the
bulk-update
branch
from
a184cbc
to
4517c77
Compare
This was referenced Jun 13, 2022
laurenceisla
force-pushed
the
bulk-update
branch
from
c17b954
to
9dda69e
Compare
laurenceisla
force-pushed
the
bulk-update
branch
from
d04ec4c
to
7bc05d3
Compare
5 tasks
3 tasks
steve-chavez
commented
Jul 30, 2022
Comment on lines
+391
to
+401
| it "does not work when no limit query or filter is given" $ | ||
| request methodPatch "/limited_update_items" | ||
| [("Prefer", "tx=commit"), ("Prefer", "count=exact")] | ||
| [json| {"name": "updated-item"} |] | ||
| `shouldRespondWith` | ||
| "" | ||
| { matchStatus = 404 | ||
| , matchHeaders = [ matchHeaderAbsent hContentType | ||
| , "Content-Range" <:> "*/0" ] | ||
| } | ||
|
|
There was a problem hiding this comment.
This error was just a lucky side-effect of #2343. This needs a clear error message plus a 422 status - like done for batch delete.
steve-chavez
commented
Jul 30, 2022
Comment on lines
+638
to
+650
| request methodPatch "/bulk_update_items" | ||
| [("Prefer", "tx=commit")] | ||
| [json|[ | ||
| { "id": 1, "name": "item-1 - 1st", "observation": "Lost item" } | ||
| , { "id": 3, "name": "item-3 - 3rd", "observation": null } | ||
| ]|] | ||
| `shouldRespondWith` | ||
| "" | ||
| { matchStatus = 204 | ||
| , matchHeaders = [ matchHeaderAbsent hContentType | ||
| , "Content-Range" <:> "0-1/*" | ||
| , "Preference-Applied" <:> "tx=commit" ] | ||
| } |
There was a problem hiding this comment.
Using the pks as filters without the option to reference other key in the body is too arbitrary. We need to be able to refer to every key, like bulk delete does.
For this, we'd need underscore operators.
2 tasks
laurenceisla
added a commit
that referenced
this pull request
Aug 12, 2022
- Revert patch #2311 - Keep the refactor done to qsFiltersRoot - Keep the refactor done to the items tables - Add tests that now work with pg-safeupdate as a result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1959.
TODO