-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to update PSResourceGet via Artifactory remote repo #1656
Comments
I see three options here:
|
@alerickson @SydneyhSmith This bug isn't something I can directly contribute a fix for since we're running up against [unexpected] behavior in the Gallery. Can someone from your team take a look here? We originally engaged JFrog support for this and have some line of dialogue with their R&D. (JFrog folks, see ticket #296792) If we need to get adjustments made in JFrog to align its behavior with other servers (thus obviating the need for quirk flags in this space), now would be an excellent time to do so. Alternatively, if your team is comfortable with munging the filter (i.e. convert from |
As mentioned in this issue, we're going to look into the Gallery codebase to see what is happening and if we can't safely make the change there then we'll open a fix client side. |
@SydneyhSmith In PowerShell/PowerShellGallery#273 you mentioned a client-side fix was likely going to be the lowest-friction solve. It's been over a month and I haven't seen any movement - is your team still working on this? If there's bandwidth constraints preventing prioritization/delivery of said fix, can someone from your team describe what the intended client-side fix was? I'm happy to provide a PR implementing option #3 described in #1656 (comment), but this feels a bit kludgy- I want to avoid adding more cruft to the codebase than is necessary. |
Prerequisites
Steps to reproduce
v2
).Update-PSResource Microsoft.PowerShell.PSResourceGet
.Expected behavior
Actual behavior
Error details
No response
Environment data
Visuals
This seems to be the combination of two separate issues:
FindPackageById()
if we detect the upstream repo is a JFrog repo. After discussing with JFrog support, they confirmed that NuGet calls like this are being passed unfettered to the upstream. This means that PSGallery is receiving subtly different API call parameters when it's being reflected through Artifactory.IsLatestVersion
, is returning unexpected results. I filed filterIsLatestVersion
returns invalid response for packageMicrosoft.PowerShell.PSResourceGet
PowerShellGallery#273 to track this.The text was updated successfully, but these errors were encountered: