Move to Omnisharp lib 0.18.x #1376
Conversation
| options.Receiver = new DapReceiver(); | ||
| options.LoggerFactory = _loggerFactory; | ||
| ILogger logger = options.LoggerFactory.CreateLogger("DebugOptionsStartup"); | ||
| options.WithSerializer(new DapProtocolSerializer()); |
There was a problem hiding this comment.
this line won't be needed for 0.18.2
test/PowerShellEditorServices.Test.E2E/DebugAdapterProtocolMessageTests.cs
Show resolved
Hide resolved
src/PowerShellEditorServices/Services/DebugAdapter/Handlers/BreakpointHandlers.cs
Outdated
Show resolved
Hide resolved
| }; | ||
| } | ||
|
|
||
| public Task<SetExceptionBreakpointsResponse> Handle(SetExceptionBreakpointsArguments request, CancellationToken cancellationToken) |
There was a problem hiding this comment.
Should this method currently return successfully? What will the behaviour be if someone tries to set an exception breakpoint? Will it just silently do nothing?
There was a problem hiding this comment.
I've not changed the code. Just moved it to a different space. There isn't a SupportsExceptionBreakpoints capability so we have to handle this message... but it seems like it just silently does nothing... very odd.
There was a problem hiding this comment.
https://microsoft.github.io/debug-adapter-protocol/specification#arrow_left-initialized-event
frontend sends a ‘setExceptionBreakpoints’ request if one or more ‘exceptionBreakpointFilters’ have been defined (or if ‘supportsConfigurationDoneRequest’ is not defined or false)
| .OnInitialize(async (server, request, cancellationToken) => { | ||
| var breakpointService = server.GetService<BreakpointService>(); | ||
| // Clear any existing breakpoints before proceeding | ||
| await breakpointService.RemoveAllBreakpointsAsync().ConfigureAwait(false); | ||
| }) | ||
| .OnInitialized((server, request, response, cancellationToken) => { | ||
| response.SupportsConditionalBreakpoints = true; | ||
| response.SupportsConfigurationDoneRequest = true; | ||
| response.SupportsFunctionBreakpoints = true; | ||
| response.SupportsHitConditionalBreakpoints = true; | ||
| response.SupportsLogPoints = true; | ||
| response.SupportsSetVariable = true; | ||
|
|
||
| return Task.CompletedTask; | ||
| }); |
There was a problem hiding this comment.
What's the difference between these? Which of them handles the Initialize request?
There was a problem hiding this comment.
I added comments in a few places to explain what we're doing here... it's a bit confusing. @david-driscoll says it's cause we're weird 😛
There was a problem hiding this comment.
Naming things is hard... so I just stuck with the protocol naming for the events.
There was a problem hiding this comment.
I need to do some more documentation on how things work, it's on my list.
| // sending configuration requests | ||
| _jsonRpcServer.SendNotification(EventNames.Initialized); | ||
| _debugStateService.ServerStarted.SetResult(true); |
There was a problem hiding this comment.
Based on this, it looks like this could be a TaskCompletionSource<bool> (that way no allocation is needed to set the value of true)
| .OnInitialize(async (server, request, cancellationToken) => { | ||
| var breakpointService = server.GetService<BreakpointService>(); | ||
| // Clear any existing breakpoints before proceeding | ||
| await breakpointService.RemoveAllBreakpointsAsync().ConfigureAwait(false); | ||
| }) | ||
| // The OnInitialized delegate gets run right before the server responds to the _Initialize_ request: | ||
| // https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Initialize |
No description provided.