Add regression test for System.Windows.Forms bug
#1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleejordan
force-pushed
the
andschwa/forms-test
branch
from
9b44259
to
c64ca5c
Compare
|
Whelp, it's passing, which isn't right! |
|
Ok, I need to actually write this test in the style of: Because it's the OmniSharp integration that is the regression to assert. |
andyleejordan
force-pushed
the
andschwa/forms-test
branch
3 times, most recently
from
182a68c
to
801e2c9
Compare
|
Ok, @rjmholt that build failure looks like the expected hang to me, I only wish I could see that locally. |
andyleejordan
force-pushed
the
andschwa/forms-test
branch
3 times, most recently
from
87fc6f4
to
14de362
Compare
|
Look at that! Regression test hung before the update, and doesn't after!!! |
andyleejordan
force-pushed
the
andschwa/forms-test
branch
from
ddfbe86
to
1dba04a
Compare
andyleejordan
commented
Aug 18, 2021
| @@ -34,8 +34,7 @@ | |||
| <PackageReference Include="xunit" Version="2.4.1" /> | |||
| <PackageReference Include="xunit.runner.visualstudio" Version="2.4.3" /> | |||
| <PackageReference Include="Xunit.SkippableFact" Version="1.4.13" /> | |||
| <PackageReference Include="OmniSharp.Extensions.LanguageServer" Version="0.19.2" /> | |||
| <DotNetCliToolReference Include="dotnet-xunit" Version="2.4.0-beta.1.build3958" /> | |||
There was a problem hiding this comment.
Not sure what on earth this DotNetCliToolReference was for, it doesn't seem needed any more.
rjmholt
approved these changes
Aug 18, 2021
andyleejordan
force-pushed
the
andschwa/forms-test
branch
from
1dba04a
to
aacef3a
Compare
So that we can build from our fork while we wait for an upcoming release.
So `v0.19.4` is out on GitHub, but has not yet released to the NuGet gallery, and I don't wish to delay this any longer. We'll let Dependabot bring that in as soon as it can be. The only thing missing is the DryIoc update, which we're simply hoping solves an issue.
andyleejordan
force-pushed
the
andschwa/forms-test
branch
from
aacef3a
to
cd29c49
Compare
|
@rjmholt I dropped this back to OmniSharp v0.19.3 as it's all that's on NuGet. v0.19.4 will come eventually, we'll just let Dependabot update it then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fail until we can update OmniSharp and so include OmniSharp/csharp-language-server-protocol#633, which fixes the bug this regression test covers. When that happens, this PR will fix:
System.Windows.Formsobjects are used vscode-powershell#3410Connect-ExchangeOnlinefails becauseSystem.Windows.Formsobjects are used vscode-powershell#3396System.Windows.Formsobjects are used, hanging extension vscode-powershell#3394 (minus a separate issue we're still working out)