Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix profile loading and $PROFILE variable #1604

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Conversation

andyleejordan
Copy link
Member

@andyleejordan andyleejordan commented Oct 29, 2021

Fixes issues identified in: PowerShell/vscode-powershell#3650

  • Profiles are loaded
  • $PROFILE is a string with value of path to CurrentUserCurrentHost
  • All profile paths are available on $PROFILE as PSNote properties
  • $PROFILE is initialized before profiles are loaded

@andyleejordan
Copy link
Member Author

Replaces #1602.

@andyleejordan andyleejordan changed the title Ensure profiles are run at startup and output is shown Fix profile loading and $PROFILE variable Nov 3, 2021
@andyleejordan
Copy link
Member Author

Tests will come with PowerShellContextServiceTests are brought back online.

@andyleejordan
Copy link
Member Author

TODO: Don't know if this will fix whitespace in path issues, and it definitely doesn't fix the PrivateData issue (which is separate).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants