Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HostInfo.BundledModulePath to find PSScriptAnalyzer #1864

Merged
merged 3 commits into from
Jul 29, 2022

Conversation

andyleejordan
Copy link
Member

Also refactor a bit so we're not triplicating this logic.

Resolves PowerShell/vscode-powershell#2697.

I need to add some tests which just ensure PSSA loads and has rules.

@andyleejordan andyleejordan marked this pull request as ready for review July 28, 2022 19:30
@andyleejordan andyleejordan requested a review from a team July 28, 2022 19:30
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan
Copy link
Member Author

Simplified the test because the Write-Host warning I guess doesn't show up with Windows PowerShell?!

@andyleejordan andyleejordan merged commit c6b7b91 into main Jul 29, 2022
@andyleejordan andyleejordan deleted the andschwa/pssa branch July 29, 2022 23:47
@andyleejordan andyleejordan mentioned this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Locally installed PSScriptAnalyzer module takes precedence over bundled one
2 participants