Add artificial stack frame to represent contexts without one #1898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeeminglyScience
changed the title
SeeminglyScience
changed the title
| if (!string.IsNullOrEmpty(scriptExtent.File) | ||
| && !PathUtils.IsPathEqual(scriptExtent.File, targetFrame.ScriptPath)) | ||
| { | ||
| await debugInfoHandle.WaitAsync().ConfigureAwait(false); |
There was a problem hiding this comment.
Normally I'd prefer to push this into the code for FetchStackFramesAndVariablesAsync but that would require giving it more context than it typically needs. Since this should be an edge case rather than the norm, I lean towards this being preferable.
That said I'm open to switching it up and just passing more context to fetch.
| /// <see cref="StringComparison.Ordinal" /> for case sensitive file systems and <see cref="StringComparison.OrdinalIgnoreCase" /> | ||
| /// in case insensitive file systems. | ||
| /// </summary> | ||
| internal static readonly StringComparison PathComparison = RuntimeInformation.IsOSPlatform(OSPlatform.Linux) |
There was a problem hiding this comment.
Platform checks are sort of littered throughout the project. It'd be nice to go through and replace these with centralized logic. (It's optimized by the JIT anyway iirc so it's not a perf boost at least outside of Windows PowerShell, but nice for maintenance)
When stepping into certain contexts like a param block's default value expression, the engine does not provide a call stack frame to represent it. In this scenario we want to create an artifical call stack frame to represent the context we've stepped into.
andyleejordan
force-pushed
the
SeeminglyScience/issue1897
branch
from
03f503f
to
ef28cd4
Compare
|
Ah ha! I figured out how to rebase it myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1897
Fixes PowerShell/vscode-powershell#4103
PR Summary
When stepping into certain contexts like a
paramblock's default value expression, the engine does not provide a call stack frame to represent it. In this scenario we want to create an artificial call stack frame to represent the context we've stepped into.PR Context