Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PowerShellEditorServices.VSCode module / ContentViews feature #2132

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

andyleejordan
Copy link
Member

As it took a year (presumably, maybe a more recent VS Code update is what broke it) to come up that indicates its usage is too low for us to go about fixing. If someone wants to figure it out we'll be happy to take a PR. For now we're removing the code (which is also a massive simplification because it was the entirety of the "VSCode" module we had to build and ship with the extension).

As it took a year (presumably, maybe a more recent VS Code update is
what broke it) to come up that indicates its usage is too low for us to
go about fixing. If someone wants to figure it out we'll be happy to
take a PR. For now we're removing the code (which is also a massive
simplification because it was the entirety of the "VSCode" module we had
to build and ship with the extension).
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad that we can decide to cut features that are not used enough!

@andyleejordan andyleejordan added this pull request to the merge queue Jan 25, 2024
@andyleejordan
Copy link
Member Author

Me too! Goal is to reduce the surface area we have to maintain. I want a stable, quality extension even if it's smaller! Not an extension trying to implement everything possible under the sun but failing at all the core features.

Merged via the queue into main with commit 40126f9 Jan 25, 2024
9 checks passed
@andyleejordan andyleejordan deleted the andyleejordan/deprecations branch January 25, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Engine Issue-Enhancement A feature request (enhancement).
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants