Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built-in PowerShell snippets can't be tabbed through #767

Closed
lipkau opened this issue May 19, 2017 · 2 comments · Fixed by #795
Closed

Built-in PowerShell snippets can't be tabbed through #767

lipkau opened this issue May 19, 2017 · 2 comments · Fixed by #795
Labels
Milestone

Comments

@lipkau
Copy link
Contributor

lipkau commented May 19, 2017

System Details

  • Operating system name and version: 10.0.14393.1066
  • VS Code version: 1.13.0-insider 613724d43b4d50f6052bbb8007447ca96e687f26
  • PowerShell extension version: [email protected]

Issue Description

When using a snippet from the extension, the placeholder are missing and the tab jumps are not working.
Screen recording of the problem:
2017-05-19_13-16-38

@PowerSchill
Copy link
Contributor

I can confirm the same issue on MacOS

ProductName: Mac OS X
ProductVersion: 10.12.5
BuildVersion: 16F73

1.13.0-insider
ec76a9fc5146b822cdb14b982ac3e5b470dd646a

@daviwil daviwil added the Issue-Bug A bug to squash. label May 19, 2017
@daviwil daviwil added this to the 1.2.0 milestone May 19, 2017
@daviwil
Copy link
Contributor

daviwil commented May 19, 2017

Argh, they probably changed something again, I'll look into it.

@daviwil daviwil changed the title Broken Snippets Built-in PowerShell snippets can't be tabbed through May 19, 2017
daviwil added a commit to daviwil/vscode-powershell that referenced this issue May 30, 2017
This change fixes some ambiguity in our snippet placeholders to confirm
with stricter parsing rules in VS Code 1.12.0.  Generally this requires
prefixing an index (`${1:Placeholder Text}`) anywhere that a placeholder
is used so that the syntax isn't ambiguous with a variable name.
Snippet variables are a separate concept now.

Resolves PowerShell#767.
daviwil added a commit that referenced this issue May 30, 2017
This change fixes some ambiguity in our snippet placeholders to confirm
with stricter parsing rules in VS Code 1.12.0.  Generally this requires
prefixing an index (`${1:Placeholder Text}`) anywhere that a placeholder
is used so that the syntax isn't ambiguous with a variable name.
Snippet variables are a separate concept now.

Resolves #767.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants