Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension host crashes after closing Integrated Console terminal #782

Closed
wsmelton opened this issue May 25, 2017 · 1 comment
Closed

Extension host crashes after closing Integrated Console terminal #782

wsmelton opened this issue May 25, 2017 · 1 comment
Milestone

Comments

@wsmelton
Copy link

wsmelton commented May 25, 2017

System Details

  • Operating system name and version: Windows 10 Pro
  • VS Code version: 1.13.0-insider
  • PowerShell extension version: 5.1
  • Output from $PSVersionTable:
C:\WINDOWS\system32> code -v
1.12.2
19222cdc84ce72202478ba1cec5cb557b71163de
C:\WINDOWS\system32> $pseditor.EditorServicesVersion
C:\WINDOWS\system32> code --list-extensions --show-versions
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
C:\WINDOWS\system32> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.1.14393.1198
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14393.1198
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Issue Description

In cases where the integrated terminal is causing code to run differently (can't explain fully but it does not compared to PowerShell.exe), I want to close the PowerShell Integrated Terminal.

Whenever I delete that from the terminal and perform an action that requires the extension to perform an action (intellisense, ect.) I get a prompt at the top of the window and am forced to reload Code.

I'm not sure if there is a consensus on this but if I'm not using the Integrated session I'd prefer it to not start at all.

vscode_ps

Logs.zip

@daviwil
Copy link
Contributor

daviwil commented May 25, 2017

There seems to be a bug here in general, thanks for letting me know about it. You can disable loading of the integrated console entirely by using this setting:

"powershell.startAutomatically": false

Note that this will disable all language features so IntelliSense, etc won't work while this is set to false. Another option is just to not show the PowerShell Integrated Console when you first open a PowerShell file:

"powershell.integratedConsole.showOnStartup": false

Language features will still be available with this setting.

@daviwil daviwil changed the title Integrated Terminal closing not allowed Extension host crashes after closing Integrated Console terminal May 25, 2017
@daviwil daviwil added this to the 1.2.0 milestone May 25, 2017
daviwil added a commit to daviwil/vscode-powershell that referenced this issue May 26, 2017
This change fixes some issues with switching and restarting the active
PowerShell session after our migration to the new vscode-languageclient
package.  They changed their error handling code in a way that caused
our shutdown process to get stuck in a loop.

Fixes PowerShell#737
Fixes PowerShell#782
daviwil added a commit to daviwil/vscode-powershell that referenced this issue May 30, 2017
This change fixes some issues with switching and restarting the active
PowerShell session after our migration to the new vscode-languageclient
package.  They changed their error handling code in a way that caused
our shutdown process to get stuck in a loop.

Fixes PowerShell#737
Fixes PowerShell#782
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants