This repository has been archived by the owner on Apr 24, 2020. It is now read-only.
Speedup VCS Segment 4 #1058
Merged
Speedup VCS Segment 4 #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We cannot detect untracked files when we are inside of a .git directory.
In this case is was previously not possible to get the untracked status. Now we temporarily change the directory to the repo root folder and then get the list of untracked files.
Changing directories while checking for untracked files broke the display of git stashes. The hook was not called any more. This is why we disabled checking for untracked files within a .git folder.
Now the untracked files are always checked from the root folder of the repo.
Closed
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way how stashes are counted. Previously the stashes were counted via
git stash list | wc -l, now they are counted without invokingwcor evengit.Secondly this fixes an issue with the untracked files: That code worked only within the current directory. So if you have untracked files in your repo root and change into a clean subdir, you never saw the untracked icon. This is now fixed.
Talking in speed:
time ( repeat 10; do; prompt_vcs "left" 1 false > /dev/null; done;)in my P9K dev repo with 65 stashes:1,57s user 1,68s system 85% cpu 3,804 total
Old segment from
next(5200a1b):2,32s user 2,58s system 83% cpu 5,864 total
@Erowlin could you double check the speed improvements?