BenoitAverty's dir Segment Improvements
#353
Conversation
| if [[ $POWERLEVEL9K_DIR_SPLIT_MODE == true ]]; then | ||
| current_path=$(print -P $current_path) | ||
| if [[ $current_path == "/" ]]; then | ||
| current_path=$(print_icon 'ICON_SLASH') |
There was a problem hiding this comment.
The icon is missing in the icons array.
And may I suggest a new name for that. I see that ROOT_ICON is already in use (and has a different meaning anyway), but what about ROOT_FOLDER_ICON?
| if [[ $current_path == "/" ]]; then | ||
| current_path=$(print_icon 'ICON_SLASH') | ||
| else | ||
| current_path=$(echo $current_path | cut -c1 | sed "s,/,$(print_icon 'ICON_SLASH') ,g")$(echo $current_path | cut -c2- | sed "s,/, $(print_icon 'LEFT_SUBSEGMENT_SEPARATOR') ,g") |
There was a problem hiding this comment.
If I understand correctly, you are replacing the first slash with ICON_SLASH and all following slashes with LEFT_SUBSEGMENT_SEPARATOR. I recently implemented such a functionality (see #346 ; but without a different icon for the first slash, which is a good idea, IMHO).
| @@ -956,6 +985,13 @@ prompt_pyenv() { | |||
| fi | |||
| } | |||
|
|
|||
| # dir_permision: Display information about the user's permission to write in the current directory | |||
| prompt_dir_permission() { | |||
There was a problem hiding this comment.
Here I would propose dir_writable as a better name.
|
Hello, I'd be glad to make these changes land into upstream and drop my own fork of powerlevel9k 😄 I'll try to find some time in the next few days to take your reviews into account and clean up a bit, rebase, etc. Are you willing to integrate all the changes or only the changes regarding "dir" segment ? Thanks for your interest in my changes :-) |
|
@BenoitAverty - I think all of your changes would be good upstream =) Don't forget that to add docs in the README for the |
|
Hey @BenoitAverty - Just keeping this on your radar! We're excited to pull this into the upstream =) |
|
Hey @bhilburn. Sorry I haven't had time to work on this yet, but I haven't forgotten ^^ Just so I don't keep your hopes up, I probably won't have time to work on this before next year, with all the holidays and all. It's on my todo list ! |
|
Hey @BenoitAverty ! |
|
Hello @dritter I'm really sorry, I don't see this happening soon. I'm having troubles finding the time and motivation to do it at the moment, and it would probably take a few hours. If someone wants to do it, I don't mind answering questions, and I have no problem letting someone take credit for this. They would need to pick the changes I made from the git history and do it cleanly. Benoit |
|
@BenoitAverty Thanks for the update. Don't worry, I'll take over your PR in the next couple of days ;) |
Hey @BenoitAverty! These are some pretty nice improvements to the
dirsegment, and we think some of them might be great contributions to the upstream! Creating this PR to get the discussion rolling.