Skip to content
This repository has been archived by the owner on Apr 24, 2020. It is now read-only.

Fix parsing package name from complex package.json files #411

Closed
wants to merge 2 commits into from

Conversation

dritter
Copy link
Member

@dritter dritter commented Feb 23, 2017

when using truncate_with_package_name strategy.

This fixes #350

when using `truncate_with_package_name` strategy.
@bhilburn
Copy link
Member

bhilburn commented Mar 8, 2017

@V1rgul @fracmak - Does this branch fix the issues discussed in #350 for you?

@fracmak
Copy link

fracmak commented Mar 8, 2017

it does, don't we need to update the README to point out installing jq will dramatically improve the parsing speed when truncate_with_package_name is specified?

@bhilburn
Copy link
Member

bhilburn commented Mar 8, 2017

Excellent point, @fracmak! I have merged this PR and made the change to the README.

Thanks for testing, @fracmak, and nice work, @dritter.

@bhilburn bhilburn closed this Mar 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants