fix duplicate id bug #791
Merged
fix duplicate id bug #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oscarlevin, do you have some PreTeXt source that reproduces this bug? If so, I'll be happy to provide a fix that avoids the exception. |
|
To reproduce, put the same xml:I'd on two elements, and put different |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codechat parses the xml it complains and causes a critical error when there are duplicate
xml:idseven if they are in separate components only one of which is included in a particularversion.This just wraps the codechat
map_path_to_xml_idin atry/exceptas a stop-gap until this is fixed. Or maybe we never fix it, since it is very unlikely someone with this sort of structure would use codechat anyway.FYI @StevenClontz and @bjones1.