Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for site.json instead of site.ptx #810

Merged
merged 5 commits into from
Aug 16, 2024

Conversation

StevenClontz
Copy link
Member

@StevenClontz StevenClontz commented Aug 1, 2024

Long-term, I'd like site.ptx to have full functionality, but since I need this today, I'm adding stopgap support for JSON files (so we can assign more than just string values to site configuration).

@StevenClontz StevenClontz marked this pull request as draft August 1, 2024 00:58
@StevenClontz StevenClontz marked this pull request as ready for review August 1, 2024 01:22
@StevenClontz
Copy link
Member Author

(i'm sneaking out a nightly release from this branch so I can use this at https://github.com/TeamBasedInquiryLearning/library so no rush to review)

Copy link
Member

@oscarlevin oscarlevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable.

@oscarlevin oscarlevin merged commit 372df68 into main Aug 16, 2024
13 checks passed
@oscarlevin oscarlevin deleted the StevenClontz/pelican-json-settings branch August 16, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants