Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saveSimList() issues #262

Merged
merged 27 commits into from
Oct 21, 2023
Merged

saveSimList() issues #262

merged 27 commits into from
Oct 21, 2023

Conversation

achubaty
Copy link
Contributor

@achubaty achubaty commented Oct 1, 2023

addresses #258 , #259, #260, #261

@eliotmcintire
Copy link
Contributor

Does this solve the hanging? #258 ? Or is the hanging happening only with qs and this fixes the forcing of .qs bug only (thus "avoiding" the hanging by allowing user to use .rds?)

@achubaty
Copy link
Contributor Author

achubaty commented Oct 2, 2023

Does this solve the hanging? #258 ? Or is the hanging happening only with qs and this fixes the forcing of .qs bug only (thus "avoiding" the hanging by allowing user to use .rds?)

It definitely hangs using .qs but not .rds, and this PR currently allows saving as .rds to bypass the qs issue. Why qs hangs / makes enormous files is still an open issue to solve.

@achubaty achubaty merged commit a119b53 into development Oct 21, 2023
15 checks passed
@achubaty achubaty deleted the saveSimList branch October 21, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants