Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

saveSimList() archives aren't using correct relative file paths #263

Closed
achubaty opened this issue Oct 2, 2023 · 2 comments · Fixed by #262
Closed

saveSimList() archives aren't using correct relative file paths #263

achubaty opened this issue Oct 2, 2023 · 2 comments · Fixed by #262
Assignees
@achubaty

Comments

@achubaty
Copy link
Contributor

achubaty commented Oct 2, 2023

absolute (not relative) paths being used, which creates highly nested folder structure and is likely non-transferable across machines.
@achubaty achubaty self-assigned this Oct 2, 2023
@achubaty achubaty linked a pull request Oct 2, 2023 that will close this issue
saveSimList() issues #262
Merged
@achubaty
Copy link
Contributor Author

achubaty commented Oct 2, 2023 •
edited
Loading

this is an issue with relativizePaths() and resolving symlinks.

reproducible:::makeRelative() is used, which is the real culprit

@achubaty achubaty mentioned this issue Oct 2, 2023
Closed
achubaty added a commit that referenced this issue Oct 19, 2023
@achubaty
improve saveSimList() + tests using symlinks
591e826 
with #263
@achubaty
Copy link
Contributor Author

this is now working, and incorporated into saveSimList() tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@achubaty achubaty

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

saveSimList() issues PredictiveEcology/SpaDES.core
1 participant
@achubaty