Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus Chart: Replace 'CHART_VERSION' with 'RELEASE_VERSION' #402

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

mitchnielsen
Copy link
Contributor

For the Prometheus Chart release, use the correct variable name.

Related to https://linear.app/prefect/issue/PLA-400/cycle-4-catch-all

@mitchnielsen mitchnielsen self-assigned this Oct 17, 2024
@mitchnielsen mitchnielsen marked this pull request as ready for review October 17, 2024 19:24
@mitchnielsen mitchnielsen requested a review from a team as a code owner October 17, 2024 19:24
Copy link
Contributor

@jimid27 jimid27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we never set a CHART_VERSION env variable?

@mitchnielsen
Copy link
Contributor Author

I believe it's a byproduct of changing variable names in #398, just needed to change it for the rest of the instances

@mitchnielsen mitchnielsen merged commit 0393728 into main Oct 17, 2024
13 checks passed
@mitchnielsen mitchnielsen deleted the fix-prometheus-release branch October 17, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants