Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport nullable flow_run_id in Log table #14830

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Backport nullable flow_run_id in Log table #14830

merged 2 commits into from
Aug 5, 2024

Conversation

zzstoatzz
Copy link
Collaborator

backport of #14828

@zzstoatzz zzstoatzz marked this pull request as ready for review August 3, 2024 00:34
@zzstoatzz zzstoatzz requested a review from a team as a code owner August 3, 2024 00:34
bunchesofdonald
bunchesofdonald reviewed Aug 5, 2024
View reviewed changes
Copy link
Contributor

@bunchesofdonald bunchesofdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this need a migration as well since we're changing the nullabiltiy of field in the db?

@zzstoatzz
Copy link
Collaborator Author

zzstoatzz commented Aug 5, 2024 •
edited
Loading

Doesn't this need a migration as well since we're changing the nullabiltiy of field in the db?

@bunchesofdonald i linked this in the other PR, but these migrations actually do exist already from the early background task work, the ORM model i think was the only thing missed

bunchesofdonald
bunchesofdonald approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@bunchesofdonald bunchesofdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I see, in that case this looks great!

@zzstoatzz zzstoatzz merged commit a3f0528 into 2.x Aug 5, 2024
23 checks passed
@zzstoatzz zzstoatzz deleted the nullable-flow-run-id-in-logs-table-2.x branch August 5, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bunchesofdonald bunchesofdonald bunchesofdonald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zzstoatzz @bunchesofdonald