Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

look for tile locations under another key in .czi metadata #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hoerldavid
Copy link
Contributor

This is a fix for missing Tile locations we encountered in a (corrupted?) CZI file (that prevented automatic loading of the whole dataset).
I found the tile location under an alternative key in the metadata, but I'm not familiar enough with CZI to assess whether looking under Experiment|AcquisitionBlock|TilesSetup|PositionGroup|Position| ... is a good idea or might cause problems with other datasets.

What are your thoughts @StephanPreibisch ? Should we merge this?

@hoerldavid
Copy link
Contributor Author

Here's how I interpret the values:

  • Information|Image|V|View|Position[X,Y,Z]|... is the actual location at which the image was taken
  • Experiment|AcquisitionBlock|TilesSetup|PositionGroup|Position| ... is where we specified the image to be taken before running the acquisition.

Normally, those should be the same. Since we only fall back to the second value if we cannot find the first (which should not happen normally) this should not change behaviour for normal datasets, but might enable us to open "slightly corrupted" data, e.g. when the acquisition was interrupted halfway through.

I think this is save to merge, so let's do that before the next release @StephanPreibisch ?

@ctrueden ctrueden force-pushed the master branch 2 times, most recently from 821d6d8 to 1e17e5b Compare May 17, 2019 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant