-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update graphql dependencies #224
Conversation
Hello @leemyongpakvn :) package-lock.json has not been updated ? |
@M0rgan01 I think package-lock.json and 14 assets files will be renewed by Build & Release workflow automatically. QA team will be happier with simple Files changed ;) |
The CI will not update your package-lock on the repository. It also seems that there are already problems with the lock file on the dev branch. A command To avoid this, you should replace
|
@M0rgan01 package.json and package-lock.json will be updated together by this PR. You can create another PR to replace |
@M0rgan01 Found it now PrestaShop/hummingbird#480 |
Thanks @leemyongpakvn , I'll do it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @leemyongpakvn , the description of you PR is lacking some informations (The tickets numbers and the sponsor company filed). If you could complete it, it would greatly help our QA team.
Also IMO, I think it could be a good idea to update the modules in differents PR if possible ( I know it's not always possible since some packages have requierments ).
For this time you can let it as is ;)
Good work anyway and thanks for the contribution.
Waiting for the result of the related discussion |
Close in favor of #250 |
graphql from 14.0.2 to 14.5.8
graphql-tag from 2.10.3 to 2.12.1
graphql-tools from 4.0.7 to 5.0.0
graphql-type-json from 0.3.1 to 0.3.2
August 12: Rebase after v3.0.1 release, lint fix and rebuild asset