Skip to content

Commit

Permalink
ok, there are more of this around. fixed all of the 'npm i'
Browse files Browse the repository at this point in the history
  • Loading branch information
tswfi committed Mar 30, 2023
1 parent b1b89c6 commit e75da3d
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 14 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

name: Build ZIP File
on:
on:
pull_request:
push:
workflow_dispatch:
Expand All @@ -19,7 +19,7 @@ jobs:
node-version: 14

- name: Install dependencies
run: npm i
run: npm ci

- name: Copy Webpack config
run: cp ./webpack/.env-example ./webpack/.env
Expand Down Expand Up @@ -50,7 +50,7 @@ jobs:
rm postcss.config.js
rm tsconfig.json
rm webpack.config.js
- name: Create & Upload artifact
uses: actions/upload-artifact@v1
with:
Expand All @@ -65,17 +65,17 @@ jobs:
uses: actions/download-artifact@v1
with:
name: ${{ github.event.repository.name }}

- id: release_info
uses: toolmantim/release-drafter@v5
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Prepare for Release
run: |
cd ${{ github.event.repository.name }}
zip -r ${{ github.event.repository.name }}.zip ${{ github.event.repository.name }}
- name: Clean existing assets
shell: bash
run: |
Expand All @@ -87,7 +87,7 @@ jobs:
done
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Publish to GitHub Release
uses: actions/[email protected]
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
node-version: ${{ matrix.node }}

- name: Install dependencies
run: npm i
run: npm ci

- name: Generate
run: npm run build-storybook
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
node-version: '14.x'

- name: Lint scss
run: npm install && npm run scss-lint
run: npm ci && npm run scss-lint
eslint:
name: ESLint
runs-on: ubuntu-latest
Expand All @@ -26,4 +26,4 @@ jobs:
node-version: '14.x'

- name: Lint js
run: touch ./webpack/.env && npm install && npm run lint
run: touch ./webpack/.env && npm ci && npm run lint
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,5 @@ jobs:
restore-keys: ${{ runner.os }}-node-

- name: Run tests
run: npm install && npm run test
run: npm ci && npm run test
working-directory: ./
2 changes: 1 addition & 1 deletion .github/workflows/typecheck.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ jobs:
node-version: '14.x'

- name: Build and check types
run: touch ./webpack/.env && npm install && npm run build
run: touch ./webpack/.env && npm ci && npm run build
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ There are few things to do before you are ready to contribute.

First you need to install every node module:

`npm i`
`npm ci`

then create a `.env` file inside the *webpack* folder by copying `webpack/.env-example` and complete it with your environment's informations. Please use a free tcp port.

Expand All @@ -35,7 +35,7 @@ then build assets:
### Good practices

- Follow the BEM convention
- Be careful about creating SCSS files in the right folder, refer to the [documentation](https://build.prestashop.com/hummingbird/) for further informations.
- Be careful about creating SCSS files in the right folder, refer to the [documentation](https://build.prestashop.com/hummingbird/) for further informations.
- When you want to submit a PR, please make sure that you ran both linters using `npm run lint-fix && npm run scss-fix` and fixed every lint issues.
- If your PR is a work in progress, make sure that you use the Github draft mode.
- Fill the PR template as much as possible, it's important to speed the process of testing, reviewing...
Expand Down

0 comments on commit e75da3d

Please sign in to comment.