Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix email subscription form UX on XS screen #344

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Fix email subscription form UX on XS screen #344

merged 2 commits into from
Nov 29, 2022

Conversation

mparvazi
Copy link
Member

@mparvazi mparvazi commented Jul 8, 2022 •
edited
Loading

Part of #340 (Newsletter block)

Before

Screenshot from 2022-07-08 20-51-41

After (With last commit)

Screenshot from 2022-07-25 11-27-11

@Hlavtox
Copy link
Contributor

Hlavtox commented Jul 9, 2022

I think we can put them like this by default (only padding-bottom) and put them on a line with bigger screen with media query. Less code. ;-)

@Hlavtox
Copy link
Contributor

Hlavtox commented Jul 9, 2022

Also, WDYT?
178031718-0eac72e5-853b-4127-9c5d-10751bb5af38

@SharakPL
Copy link
Contributor

SharakPL commented Jul 9, 2022

How about full width button when it's under the input? Otherwise this version is good. Could be also > instead of Subscribe for mobile.

@mparvazi mparvazi marked this pull request as draft July 12, 2022 08:46
@mparvazi mparvazi marked this pull request as ready for review July 25, 2022 07:02
@Hlavtox Hlavtox merged commit ca504fb into PrestaShop:develop Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeOMakinG NeOMakinG NeOMakinG approved these changes

@atomiix atomiix atomiix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mparvazi @Hlavtox @SharakPL @atomiix @NeOMakinG