refactor(visible-password): simplify code #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
davidglezz
commented
Nov 24, 2022
davidglezz
commented
| Questions | Answers |
|---|---|
| Description? | Simplify visible-password logic and rename var names because we are in the visible password context (https://github.com/labs42io/clean-code-typescript#dont-add-unneeded-context). |
| Type? | refacto |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | no |
| How to test? | no |
| Possible impacts? | visible-password |
Signed-off-by: davidglezz <[email protected]>
Signed-off-by: davidglezz <[email protected]>
Signed-off-by: davidglezz <[email protected]>
davidglezz
force-pushed
the
simplify-visible-password
branch
from
ee997f2
to
11a59c7
Compare
davidglezz
changed the title
0x346e3730
approved these changes
Nov 30, 2022
NeOMakinG
approved these changes
Dec 1, 2022
|
Thanks @davidglezz 🍬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.