Backport classic fixes since making hummingbird #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JBLach
commented
Dec 2, 2022
•
JBLach
commented
| Questions | Answers |
|---|---|
| Description? | I went through all commits from classic theme since the start of himmingbird. Added missing things, or replaced with the current ones from the classic theme |
| Type? | improvement |
| Deprecations? | yes |
| Fixed ticket? | Fixes #389 |
NeOMakinG
reviewed
Dec 2, 2022
templates/_partials/header.tpl
Outdated
Comment on lines
54
to
60
| {if $shop.logo_details} | ||
| {if $page.page_name == 'index'}<h1>{/if} | ||
| <a class="navbar-brand" href="{$urls.pages.index}"> | ||
| {renderLogo} | ||
| </a> | ||
| {if $page.page_name == 'index'}</h1>{/if} | ||
| {/if} |
There was a problem hiding this comment.
Did you test this? How does it react?
I'll pull up the branch in a few minutes to do a few checks
We will need to think about it for the picture tag feature
There was a problem hiding this comment.
Yes i tested it, it behaves the same as before, i only sent a correction, because i left the tag in the tag
|
@Hlavtox feel free to merge if you approve 🚀 or any others @PrestaShop/prestashop-maintainers |
atomiix
approved these changes
Dec 6, 2022
kpodemski
approved these changes
Dec 6, 2022
|
Thank you @JBLach 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.