Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch some images to picture tags #403

Merged
merged 4 commits into from
Dec 9, 2022
Merged

Switch some images to picture tags #403

merged 4 commits into from
Dec 9, 2022

Conversation

NeOMakinG
Copy link
Contributor

Questions Answers
Description? We want to use picture tags everywhere we have some images and these parts were missing
Type? improvement
BC breaks? no
Deprecations? no
How to test? Images on every part should work as expected
Possible impacts? Images display

@NeOMakinG NeOMakinG marked this pull request as draft December 7, 2022 10:59
@NeOMakinG NeOMakinG marked this pull request as ready for review December 7, 2022 13:58
@NeOMakinG NeOMakinG requested review from Hlavtox and a team December 7, 2022 13:58
Hlavtox
Hlavtox approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@Hlavtox Hlavtox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just check the legends, good otherwise!

SharakPL
SharakPL requested changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@SharakPL SharakPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some indentations + legend @Hlavtox mentioned.
Also maybe we could limit the size of the tags eg. put type next to source:

<source type="image/avif"
  srcset="..."
>

templates/customer/_partials/order-detail-no-return.tpl Outdated Show resolved Hide resolved
templates/customer/_partials/order-detail-return.tpl Outdated Show resolved Hide resolved
@NeOMakinG
Copy link
Contributor Author

Thanks a lot for the review @SharakPL @Hlavtox , I'll fix that tomorrow

@Hlavtox Hlavtox requested a review from SharakPL December 9, 2022 10:19
@Hlavtox
Copy link
Contributor

Hlavtox commented Dec 9, 2022

@SharakPL Merge it when you check it ;-)

@SharakPL SharakPL merged commit 4864e86 into PrestaShop:develop Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hlavtox Hlavtox Hlavtox approved these changes

@SharakPL SharakPL SharakPL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NeOMakinG @Hlavtox @SharakPL