Improvements : small theme improvements #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hlavtox
approved these changes
Jun 30, 2023
|
@tblivet Good job dude, I love the level of attention to details! 🔥 |
SharakPL
approved these changes
Jul 1, 2023
| @@ -20,7 +20,7 @@ | |||
| aria-hidden="{if $smarty.foreach.homeslider.first}false{else}true{/if}"> | |||
| {if !empty($slide.url)}<a class="carousel-link" href="{$slide.url}">{/if} | |||
| <figure class="carousel-content"> | |||
| <img src="{$slide.image_url}" alt="{$slide.legend|escape}" loading="lazy" {$slide.size|replace: '"':''}> | |||
| <img src="{$slide.image_url}" alt="{$slide.legend|escape}" {if $slide@iteration == 1}loading="eager"{else}loading="lazy"{/if} {$slide.size|replace: '"':''}> | |||
There was a problem hiding this comment.
Suggested change
| <img src="{$slide.image_url}" alt="{$slide.legend|escape}" {if $slide@iteration == 1}loading="eager"{else}loading="lazy"{/if} {$slide.size|replace: '"':''}> | |
| <img src="{$slide.image_url}" alt="{$slide.legend|escape}" {if $slide@first}loading="eager"{else}loading="lazy"{/if} {$slide.size|replace: '"':''}> |
But since loading="eager" is the default then it would be best to only add loading="lazy" for every item except the first one.
Comment on lines
10
to
14
| &-container { | ||
| align-items: center; | ||
| margin: 1rem 0; | ||
| margin-top: 1rem; | ||
| margin-bottom: 1rem; | ||
| } |
There was a problem hiding this comment.
I'd rather add proper classes to the template (my-3 align-items-center) instead of duplicating CSS that is already in Bootstrap. The theme should be as light as possible. Custom CSS should be added only to custom components that can't be styled directly with BS or in loops to limit the size of compiled php file
hibatallahAouadni
approved these changes
Jul 3, 2023
There was a problem hiding this comment.
Hello @tblivet
- The breadcrumb has been removed in smarty from the homepage ✔️
- The loading attribute of ps_imageslider images has been optimized ✔️
- Improve the responsiveness of the pagination on category pages ✔️
LGTM, QA ✔️
Thanks!
|
thank you @tblivet 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eagerwhich is better in terms of performance because the first image is identified as the LCP.