Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Bad display in the prices filters while uncheck one of the filters #539

Merged
merged 1 commit into from
Aug 10, 2023
Merged

fix: Bad display in the prices filters while uncheck one of the filters #539

merged 1 commit into from
Aug 10, 2023

Conversation

tblivet
Copy link
Contributor

@tblivet tblivet commented Aug 8, 2023

Questions Answers
Description? Correct the issue 534
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixe #534
Sponsor company @PrestaShopCorp
How to test? You can refer to the issue

@mflasquin mflasquin changed the title fix: issue 534 fix: Bad display in the prices filters while uncheck one of the filters Aug 10, 2023
aniszr
aniszr approved these changes Aug 10, 2023
View reviewed changes
Copy link

@aniszr aniszr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tblivet

I tested your PR and all problems mentioned in realed issue are solved, LGTM ✔️
See attached screenrecord :

Accessories.mp4

All display problem are solved, QA:heavy_check_mark:

Thank you!

@aniszr aniszr self-assigned this Aug 10, 2023
@jolelievre
Copy link
Contributor

Thanks @tblivet

@jolelievre jolelievre merged commit d74b09d into PrestaShop:develop Aug 10, 2023
6 checks passed
@tblivet tblivet mentioned this pull request May 21, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aniszr aniszr aniszr approved these changes

@mflasquin mflasquin mflasquin approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

Assignees

@aniszr aniszr

Labels
QA ✔️
Projects
PR Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tblivet @jolelievre @matthieu-rolland @mflasquin @aniszr