Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add psgdpr displayCustomerAccount, fixes #525 #573

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

tswfi
Copy link
Contributor

@tswfi tswfi commented Dec 20, 2023

Questions Answers
Description? Hook registration for psgdpr was missing thus no GDPR in "my account"
Type? new feature
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #525
Sponsor company
How to test? Reactivate the theme (and maybe remove the config/themes/hummingbird/shop1.json first (not sure, I always remove it when changing the theme config as it is sometimes required). Check "My Account" page that GDPR section is there.

Copy link

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tswfi ,

Thanks for the PR ! LGTM :

Screenshot 2023-12-22 at 10 41 11

@SharakPL SharakPL merged commit a41001b into PrestaShop:develop Jan 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

GDPR-FO-The GDPR module doesn't work when using Hummingbird theme
6 participants