Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add auth to healthcheck #294

Merged
merged 5 commits into from
May 23, 2024
Merged

feat: add auth to healthcheck #294

merged 5 commits into from
May 23, 2024

Conversation

fox-john
Copy link
Contributor

@fox-john fox-john commented May 20, 2024 •
edited
Loading

Add check of job_id for secure healthcheck sensible data.

2 behavior exist :

  • No job_id or wrong job_id = less response without sensible data
  • Job_id is present and good = full response with sensible data

@fox-john fox-john marked this pull request as ready for review May 21, 2024 13:54
@fox-john fox-john self-assigned this May 21, 2024
@fox-john fox-john requested a review from jokesterfr May 21, 2024 13:54
@fox-john fox-john added the 🥕 Radis to review Ready to reviewed by 1 peer label May 21, 2024
@fox-john fox-john merged commit ee6cdd0 into main May 23, 2024
11 of 15 checks passed
@fox-john fox-john deleted the feature/healthcheck-v2 branch May 23, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jokesterfr jokesterfr jokesterfr approved these changes

@Venatum Venatum Venatum approved these changes

@guillaume60240 guillaume60240 guillaume60240 approved these changes

Assignees

@fox-john fox-john

Labels
🥕 Radis to review Ready to reviewed by 1 peer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fox-john @jokesterfr @Venatum @guillaume60240