Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/confidentiality issue #360

Merged
merged 7 commits into from
Sep 13, 2024
Merged

fix/confidentiality issue #360

merged 7 commits into from
Sep 13, 2024

Conversation

jokesterfr
Copy link
Contributor

@jokesterfr jokesterfr commented Sep 13, 2024

I guess we wanted to disable some data to be exposed here, this code should have not been commented.
Introduced by: https://github.com/PrestaShopCorp/ps_eventbus/pull/328/files
Found in:

@jokesterfr jokesterfr self-assigned this Sep 13, 2024
@jokesterfr jokesterfr added the 🥕 Radis to review Ready to reviewed by 1 peer label Sep 13, 2024
Copy link
Contributor

@Clap404 Clap404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jokesterfr jokesterfr merged commit 35eb61f into main Sep 13, 2024
17 of 21 checks passed
@jokesterfr jokesterfr deleted the fix/confidentiality-issue branch September 13, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥕 Radis to review Ready to reviewed by 1 peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants