Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cart rule incremental sync #382

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix: cart rule incremental sync #382

merged 1 commit into from
Oct 17, 2024

Conversation

fox-john
Copy link
Contributor

fix cart rule date send for incremental sync, and fix problem when deleted hook are called.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@fox-john fox-john added the 🥕 Radis to review Ready to reviewed by 1 peer label Oct 17, 2024
Clap404
Clap404 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@Clap404 Clap404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@fox-john fox-john merged commit b9d16b5 into main Oct 17, 2024
22 of 24 checks passed
@fox-john fox-john deleted the fix/cart-rule-incremental branch October 17, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Clap404 Clap404 Clap404 approved these changes

@davidPrestashop davidPrestashop davidPrestashop approved these changes

Assignees

@fox-john fox-john

Labels
🥕 Radis to review Ready to reviewed by 1 peer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fox-john @Clap404 @davidPrestashop