Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MBO-604] Track module upgrades on Distribution API #413

Merged
merged 3 commits into from
Jan 23, 2023
Merged

[MBO-604] Track module upgrades on Distribution API #413

merged 3 commits into from
Jan 23, 2023

Conversation

sowbiba
Copy link
Contributor

@sowbiba sowbiba commented Jan 16, 2023

Questions Answers
Branch? 2.0.x
Description? Send tracking data to Distribution API on module MBO upgrades. This is done by upgrade script when upgrading to 2.0.3 and by subcriber for any future version
Type? new feature
BC breaks? no
Deprecations? no
Fixed ticket? Fixes MBO-604

@sowbiba sowbiba force-pushed the track-mbo-upgrades branch 2 times, most recently from 5aa2575 to 4e05e08 Compare January 17, 2023 08:58
intraordinaire
intraordinaire reviewed Jan 17, 2023
View reviewed changes
Copy link
Contributor

@intraordinaire intraordinaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems great to me.
Just not a big fan to throw exceptions in the UpgradeTracker, because it will display an error toaster when the user upgrade, but, in facts, the module is well upgraded.

@sowbiba
Copy link
Contributor Author

sowbiba commented Jan 18, 2023

Seems great to me. Just not a big fan to throw exceptions in the UpgradeTracker, because it will display an error toaster when the user upgrade, but, in facts, the module is well upgraded.

I'll make a log instead and will not block the upgrade because of failed tracking

@sowbiba sowbiba merged commit 4ae76b4 into PrestaShopCorp:2.0.x Jan 23, 2023
@sowbiba sowbiba deleted the track-mbo-upgrades branch January 23, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@intraordinaire intraordinaire intraordinaire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sowbiba @intraordinaire