Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MME-429] Fix/php version min #767

Merged
merged 3 commits into from
Jul 29, 2024
Merged

[MME-429] Fix/php version min #767

merged 3 commits into from
Jul 29, 2024

Conversation

intraordinaire
Copy link
Contributor

Removed typehint from basefile

@intraordinaire intraordinaire changed the title Fix/php version min [MME-429] Fix/php version min Jul 12, 2024
@@ -346,7 +346,7 @@ public function installTabs()
*
* @return bool
*/
public function installTab(array $tabData)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI array and class names are possible options on PHP 5. The only ones you have to remove are the rest of primitive types (string, int)

Copy link

sonarcloud bot commented Jul 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
7 Security Hotspots
D Reliability Rating on New Code (required ≥ A)
D Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@intraordinaire intraordinaire merged commit abf3a5c into 2.4.x Jul 29, 2024
13 of 14 checks passed
@intraordinaire intraordinaire deleted the fix/php_version_min branch July 29, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants