Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: [Avatar-Storybook] - fix #356 #357

Conversation

mattgoud
Copy link
Collaborator

@mattgoud mattgoud commented Jul 5, 2024

❓ Types of changes

Avatar photo variant : change src img in storybook (static img to prevent rerunning UI test for each chromatic build)

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • πŸ“¦ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

@mattgoud mattgoud merged commit 74edc5b into main Jul 5, 2024
3 of 5 checks passed
@mattgoud mattgoud deleted the 356-storybookavatar-source-static-images-to-prevent-rerunning-chromatic-ui-tests-on-github branch July 5, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Storybook][Avatar] - source static images to prevent rerunning chromatic ui tests on github
1 participant