Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table] [Accessibility] fix #362 - keyboard handling : expand/collapse line with space #367

Conversation

mattgoud
Copy link
Collaborator

@mattgoud mattgoud commented Aug 1, 2024

❓ Types of changes

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • 📦 New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

keyboard handling: expand/collapse line with space

📝 Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

…on focusable and ability to expand/collapse line with space
@mattgoud mattgoud changed the title feat: [Table-expandable-rows] [Accessibility] fix #362 make expand ic… [Table] [Accessibility] fix #362 - keyboard handling : expand/collapse line with space Sep 4, 2024
@mattgoud mattgoud marked this pull request as ready for review September 4, 2024 21:11
@mattgoud mattgoud self-assigned this Sep 5, 2024
…uncheckcheckexpandable-checkbox-radio-expandable-components
…uncheckcheckexpandable-checkbox-radio-expandable-components
…uncheckcheckexpandable-checkbox-radio-expandable-components
@mattgoud mattgoud merged commit 2d85aa1 into main Sep 18, 2024
5 checks passed
@mattgoud mattgoud deleted the 362-feature-accessibility-no-possibility-to-uncheckcheckexpandable-checkbox-radio-expandable-components branch September 18, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant