Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extend line highlight to full line when nested inside scroll container #3011

Merged
merged 3 commits into from
Aug 3, 2021
Merged

extend line highlight to full line when nested inside scroll container #3011

merged 3 commits into from
Aug 3, 2021

Conversation

kuceb
Copy link
Contributor

@kuceb kuceb commented Jul 26, 2021

before:
21-07-26_17:29::28
21-07-26_17:29::33

after:
image

  • test

@github-actions
Copy link

github-actions bot commented Jul 26, 2021 •
edited
Loading

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +16 B (+1.1%).

file master pull size diff % diff
plugins/line-highlight/prism-line-highlight.min.js 1.43 KB 1.45 KB +16 B +1.1%

Generated by 🚫 dangerJS against f337301

RunDevelopment
RunDevelopment requested changes Jul 27, 2021
View reviewed changes
Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @bkucera!

plugins/line-highlight/prism-line-highlight.js Outdated Show resolved Hide resolved
@RunDevelopment
Copy link
Member

Also, please rebuild Prism by running npm ci && npm run build.

@RunDevelopment RunDevelopment merged commit e289ec6 into PrismJS:master Aug 3, 2021
@RunDevelopment
Copy link
Member

Thank you for contributing @bkucera!

@RunDevelopment RunDevelopment mentioned this pull request Aug 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RunDevelopment RunDevelopment RunDevelopment approved these changes

Assignees
No one assigned
Labels
enhancement needs changes plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuceb @RunDevelopment