1.17.1 support

[Pandapip1]

Blocked by PrismarineJS/diamond-square#15, PrismarineJS/prismarine-provider-anvil#73.

[rom1504]

Looks like tests are passing.

Do things seem to work?

[rom1504]

The name of the feature seems unrelated with the content of this if

[Pandapip1]

Copied directly from mineflayer code.

[rom1504]

https://github.com/PrismarineJS/mineflayer/blob/5c71edf48bb2f2dfa16cddb9af5baa0c4d55cf0d/lib/plugins/blocks.js#L264 definitely has the same issue

[Pandapip1]

Looks like tests are passing.

Do things seem to work?

THINGS DO NOT WORK. Particularly, world saving is completely borked and sometimes the server crashes when trying to send chunk packets (all to do with the palette set to null error).

[rom1504]

I made PrismarineJS/prismarine-provider-anvil#74 which I think should fix this anvil problem

Can you check if that helps the error you were seeing @Pandapip1 ?

[socket-security]

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/[email protected]

View full report↗︎

[Pandapip1]

I'm still getting the following error, even after updating:

January 14th 2024, 16:30:13 [ERROR]: -------------------------------
January 14th 2024, 16:30:13 [ERROR]: Please report this flying-squid! This is bug (mabye)
January 14th 2024, 16:30:13 [ERROR]: Something went wrong!
January 14th 2024, 16:30:13 [ERROR]: Error: TypeError: this.sectionMask.toLongArray is not a function
    at ChunkColumn.getMask (/home/gavin/repos/flying-squid/node_modules/prismarine-chunk/src/pc/1.17/ChunkColumn.js:244:31)
    at /home/gavin/repos/flying-squid/src/lib/plugins/world.js:188:23
    at Entity.behavior (/home/gavin/repos/flying-squid/src/lib/behavior.js:24:14)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async player.login (/home/gavin/repos/flying-squid/src/lib/plugins/login.js:222:5)
    at async Server.<anonymous> (/home/gavin/repos/flying-squid/src/lib/plugins/login.js:29:7)
January 14th 2024, 16:30:13 [ERROR]: Report this error here: https://github.com/PrismarineJS/flying-squid/issues
January 14th 2024, 16:30:13 [ERROR]: -------------------------------
January 14th 2024, 16:30:13 Server shutting down...

[rom1504]

ok that's a different error than the palette

[rom1504]

would be great to have a test showing this, would make it faster to debug

[rom1504]

PrismarineJS/prismarine-provider-anvil#75 / PrismarineJS/prismarine-provider-anvil#73 is the blocker here

[privt00]

hey
i think i made progress

getting now this error

March 29th 2024, 18:47:08 [ERROR]: Error: TypeError: this.skyLightMask.toLongArray is not a function
at ChunkColumn.dumpLight (C:\Users\Noah\Documents\mclient\node_modules\prismarine-chunk\src\pc\1.17\ChunkColumn.js:379:61)
at C:\Users\Noah\Documents\mclient\src\lib\plugins\world.js:245:20
at Entity.behavior (C:\Users\Noah\Documents\mclient\fly-high\src\lib\behavior.js:24:14)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

after world safe in 1.17.1 but yeah im tryng to fix it at moment i just dont know if its has somthing to do whit the anvil or just whit the chunkColumn.js

[privt00]

i also try fixing redstone like piston activated and all stuff

[privt00]

i fixed this error

[privt00]

just need to fix the lightnigs

[privt00]

ok made now the 1.17.1 support

[privt00]

oh no relised world dosnt safe you just can join and build but nothing gets saved

[privt00]

@rom1504 in which file is the savin logik?

[rom1504]

This repo PrismarineJS/prismarine-provider-anvil#73