Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create new defineable methods to customize behaviour of NestedStateMachine #197

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

kaduvert
Copy link
Contributor

@kaduvert kaduvert commented Nov 23, 2023

makes NestedStateMachine call onStateMachineEntered() / stateMachineUpdate() / onStateMachineExited() respectively on enter / update / exit events if they are defined

@rom1504
Copy link
Member

rom1504 commented Dec 17, 2023

this is a breaking change right?

@kaduvert
Copy link
Contributor Author

kaduvert commented Dec 17, 2023

no, it changes names of functions with internal logic, which is accounted for by renaming all internal references.

no.

@kaduvert kaduvert changed the title make the enter, update & exit functions of NestedStateMachine overwriteable expose methods to customize state behaviour on NestedStateMachine Dec 18, 2023
@kaduvert
Copy link
Contributor Author

i updated it so that instead of moving logic to make room for overwriting methods, it now just calls newly defineable methods if they're present

this now breaks nothing; only additions

@kaduvert kaduvert changed the title expose methods to customize state behaviour on NestedStateMachine create new defineable methods to customize behaviour of NestedStateMachine Dec 18, 2023
@sefirosweb
Copy link
Contributor

@kaduvert, if the bot exits 3 nested states, will it call them all respectively?

@kaduvert
Copy link
Contributor Author

yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting for user input
Development

Successfully merging this pull request may close these issues.

3 participants