Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added backtracking algorithm named all permutations of a string/array #377

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brijeshsos66
Copy link

@brijeshsos66 brijeshsos66 commented Oct 1, 2020

Added all_permutations.hpp in include folder & all_permutations.cpp in test folder.

Issue #376

@alxmjo
Copy link
Collaborator

alxmjo commented Oct 4, 2020

This looks good on first glance, but please read the documentation regarding testing code (you need to update CMakeLists.txt so that we can test your code). Also, there is an existing README for backtracking algorithms (in the same directory where you added the algorithm implementation). Please update that.

@alxmjo
Copy link
Collaborator

alxmjo commented Dec 6, 2020

Sorry for the late response, @brijeshsos66, but I just realized that you made those changes in another PR that has since been closed. Can you add those changes on this branch so they're contained in the same PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backtracking Changes requested Review pending PR looks good at first glance, needs a full review String
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants