Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 763 - show editor in Geojson namespace #767

Conversation

thomas-topway-it
Copy link
Contributor

fixes #763 (GeoJson namespace shows json instead of map editor from MW 1.38)

-- fallback to standard fillParserOutput (with standard MW json format) if SMW integration is disabled

see here for reference 98765af

@JeroenDeDauw
Copy link
Member

Did you manually verify this?

Bit annoying the tests are failing:

@thomas-topway-it thomas-topway-it marked this pull request as draft February 15, 2024 17:38
@thomas-topway-it
Copy link
Contributor Author

converted to draft since as reported by @krabina addMapHtmlToOutput is independent from smwIntegrationIsEnabled(), I will update it as soon as possible

@thomas-topway-it thomas-topway-it marked this pull request as ready for review March 19, 2024 10:42
@krabina
Copy link
Contributor

krabina commented Mar 26, 2024

You can see it in action here: https://test.knowledge.wiki/GeoJson:BG_Innere_Stadt

@JeroenDeDauw
Copy link
Member

CI is still not passing

@JeroenDeDauw JeroenDeDauw merged commit 04f3f89 into ProfessionalWiki:master Mar 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GeoJson: pages show json instead of map as of MW 1.39
3 participants